RE: [PATCH v2 2/5] remoteproc: imx_rproc: Add runtime ops copy to support dynamic behavior

[Peng Fan]

> Subject: Re: [PATCH v2 2/5] remoteproc: imx_rproc: Add runtime ops
> copy to support dynamic behavior
> 
> > -1056,6 +1052,9 @@ static int imx_rproc_probe(struct
> platform_device *pdev)
> >   	priv->dcfg = dcfg;
> >   	priv->dev = dev;
> >
> > +	if (dcfg->ops)
> > +		priv->ops = dcfg->ops;
> 
> Will priv->ops ever be modified after initialization in a multi-threaded
> context?
> If so, you might need synchronization.

This is in probe phase, no multi-thread context.

> 
> Also, you can remove the NULL check since it's safe to assign NULL.

Yes.

Thanks,
Peng.

> 
> Iulia
> 
> > +
> >   	dev_set_drvdata(dev, rproc);
> >   	priv->workqueue = create_workqueue(dev_name(dev));
> >   	if (!priv->workqueue) {
> >