Re: [PATCH v5 09/17] vfs: clean up argument list for vfs_create()

[NeilBrown]

On Thu, 06 Nov 2025, Jeff Layton wrote:
> As Neil points out:
> 
> "I would be in favour of dropping the "dir" arg because it is always
> d_inode(dentry->d_parent) which is stable."
> 
> ...and...
> 
> "Also *every* caller of vfs_create() passes ".excl = true".  So maybe we
> don't need that arg at all."
> 
> Drop both arguments from vfs_create() and fix up the callers.
> 
> Suggested-by: NeilBrown <neilb@xxxxxxxxxxx>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>

This I like.

Reviewed-by: NeilBrown <neil@xxxxxxxxxx>

It would be consistent to also remove the 'dir' arg from vfs_mkdir(),
vfs_mknod(), etc.  I wouldn't do that until we find out what other
people think of the change.

Thanks,
NeilBrown