Re: [PATCH 5.15 000/411] 5.15.186-rc1 review

[Kees Cook]

On Wed, Jun 25, 2025 at 09:39:45AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Jun 25, 2025 at 07:15:24AM +0530, Naresh Kamboju wrote:
> > On Tue, 24 Jun 2025 at 15:48, Greg Kroah-Hartman
> > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > On Tue, Jun 24, 2025 at 02:12:05AM +0530, Naresh Kamboju wrote:
> > > > On Mon, 23 Jun 2025 at 18:39, Greg Kroah-Hartman
> > > > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > > > >
> > > > > This is the start of the stable review cycle for the 5.15.186 release.
> > > > > There are 411 patches in this series, all will be posted as a response
> > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > >
> > > > > Responses should be made by Wed, 25 Jun 2025 13:05:51 +0000.
> > > > > Anything received after that time might be too late.
> > > > >
> > > > > The whole patch series can be found in one patch at:
> > > > >         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.186-rc1.gz
> > > > > or in the git tree and branch at:
> > > > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > > > > and the diffstat can be found below.
> > > > >
> > > > > thanks,
> > > > >
> > > > > greg k-h
> > > >
> > > > Regressions on arm64 allyesconfig builds with gcc-12 and clang failed on
> > > > the Linux stable-rc 5.15.186-rc1.
> > > >
> > > > Regressions found on arm64
> > > > * arm64, build
> > > >   - gcc-12-allyesconfig
> > > >
> > > > Regression Analysis:
> > > >  - New regression? Yes
> > > >  - Reproducibility? Yes
> > > >
> > > > Build regression: stable-rc 5.15.186-rc1 arm64
> > > > drivers/scsi/qedf/qedf_main.c:702:9: error: positional initialization
> > > > of field in 'struct' declared with 'designated_init' attribute
> > > >
> > > > Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>
> > > >
> > > > ## Build errors
> > > > drivers/scsi/qedf/qedf_main.c:702:9: error: positional initialization
> > > > of field in 'struct' declared with 'designated_init' attribute
> > > > [-Werror=designated-init]
> > > >   702 |         {
> > > >       |         ^
> > > > drivers/scsi/qedf/qedf_main.c:702:9: note: (near initialization for
> > > > 'qedf_cb_ops')
> > > > cc1: all warnings being treated as errors
> > >
> > > I saw this locally, at times, it's random, not always showing up.  Turn
> > > off the gcc randconfig build option and it goes away, which explains the
> > > randomness I guess.
> > >
> > > If you can bisect this to a real change that causes it, please let me
> > > know, I couldn't figure it out and so just gave up as I doubt anyone is
> > > really using that gcc plugin for that kernel version.
> > 
> > You are right !
> > The reported arm64 allyesconfig build failures are due to,
> > 
> >   randstruct: gcc-plugin: Remove bogus void member
> >   [ Upstream commit e136a4062174a9a8d1c1447ca040ea81accfa6a8 ]
> 
> Thanks for the bisection, for some reason that wasn't working for me.
> I've dropped this, and the other randstruct change from 5.15.y and older
> kernels now.

This thread got pointed out to me. You can put this back in if you want;
you just need the other associated fix (which had a bit of an obscure
Fixes tag):

d8720235d5b5 ("scsi: qedf: Use designated initializer for struct qed_fcoe_cb_ops")

-Kees

-- 
Kees Cook