Re: [PATCH] vfs: remove the excl argument from the ->create() inode_operation

[NeilBrown]

On Thu, 06 Nov 2025, Jeff Layton wrote:
> Since ce8644fcadc5 ("lookup_open(): expand the call of vfs_create()"),
> the "excl" argument to the ->create() inode_operation is always set to
> true. Remove it, and fix up all of the create implementations.

nonono


> @@ -3802,7 +3802,7 @@ static struct dentry *lookup_open(struct nameidata *nd, struct file *file,
>  		}
>  
>  		error = dir_inode->i_op->create(idmap, dir_inode, dentry,
> -						mode, open_flag & O_EXCL);
> +						mode);

"open_flag & O_EXCL" is not the same as "true".

It is true that "all calls to vfs_create() pass true for 'excl'"
The same is NOT true for inode_operations.create.

NeilBrown