Re: [PATCH v6 3/4] gpu: nova-core: make Architecture behave as a u8 type
From: Timur Tabi
Date: Sat Nov 08 2025 - 00:04:10 EST
On Fri, 2025-11-07 at 20:39 -0800, John Hubbard wrote:
> /// Enum representation of the GPU generation.
> -#[derive(fmt::Debug)]
> +#[derive(fmt::Debug, Default, Copy, Clone)]
> +#[repr(u8)]
> pub(crate) enum Architecture {
> + #[default]
> Turing = 0x16,
> Ampere = 0x17,
> Ada = 0x19,
> @@ -142,6 +144,13 @@ fn try_from(value: u8) -> Result<Self> {
> }
> }
Does it make sense to designate a default Architecture? Turing is not a fallback for Ampere --
you can't boot an Ampere with Turing's HAL. Also, we don't even make Turing cards any more, so
over time, Turing will be less and less common.