Re: [PATCH 0/3] riscv: soc: re-organized allwinner

[Jernej Škrabec]

Hi,

Dne sobota, 8. november 2025 ob 09:20:22 Srednjeevropski standardni čas je gaohan@xxxxxxxxxxx napisal(a):
> From: Han Gao <gaohan@xxxxxxxxxxx>
> 
> Allwinner currently offers d1(s)/v821/v861/v881 on RISC-V,
> using different IPs.
> 
> d1(s): Xuantie C906
> v821: Andes A27 + XuanTie E907
> v861/v881: XuanTie C907
> 
> Han Gao (3):
>   riscv: soc: re-organized allwinner menu
>   riscv: soc: allwinner: d1: use the ARCH_SUNXI_XUANTIE
>   riscv: defconfig: enable SUNXI_XUANTIE and SUNXI_ANDES

This series is incomplete. It introduces ARCH_SUNXI_ANDES symbol but it is
never used.

Additionally, patches are not organized properly. First, you should introduce
reorganization and only then introduce new features. Also, not a single
patch should break existing functionality for bisectability reasons. First
patch breaks compilation of DT files while second restores that. This must
not happen.

Best regards,
Jernej

> 
>  arch/riscv/Kconfig.socs                | 22 +++++++++++++++++-----
>  arch/riscv/boot/dts/allwinner/Makefile | 20 ++++++++++----------
>  arch/riscv/configs/defconfig           |  2 ++
>  3 files changed, 29 insertions(+), 15 deletions(-)
> 
>