Re: [PATCH v2 01/11] md/raid1: simplify uptodate handling in end_sync_write

From: Yu Kuai
Date: Sat Nov 08 2025 - 05:02:19 EST


在 2025/11/6 19:59, linan666@xxxxxxxxxxxxxxx 写道:

> In end_sync_write, r1bio state is always set to either R1BIO_WriteError
> or R1BIO_MadeGood. Consequently, put_sync_write_buf() never takes the
> 'else' branch that calls md_done_sync(), making the uptodate parameter
> have no practical effect.
>
> Pass 1 to put_sync_write_buf(). A more complete cleanup will be done in
> a follow-up patch.
>
> Signed-off-by: Li Nan<linan122@xxxxxxxxxx>
> ---
> drivers/md/raid1.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

LGTM
Reviewed-by: Yu Kuai <yukuai@xxxxxxxxx>