Re: [PATCH 3/3] regulator: Add FP9931/JD9930 driver

[Andreas Kemnade]

On Sat, 8 Nov 2025 13:21:57 +0100
Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:

> > +static struct i2c_driver fp9931_i2c_driver = {
> > +	.driver = {
> > +		   .name = "fp9931",
> > +		   .owner = THIS_MODULE,  
> 
> Please do not send us 12 year old code... Drop and runstandard tools
> (smatch, sparse, cocci) at minimum.

Yes, .owner gets handled automatically. And it should be detected by cocci.

To me it sounds like you are saying I would dig out 12 year old code
somewhere and send it totally unmodernized and unchecked. As a
device tree maintainer, you must have seen that I am using the newer unified
device property API and also other newer stuff and e.g. no
pm_runtime_mark_last_busy(). So just to make it clear to other maintainers
what they are dealing with, most of the stuff is new.

Most.. So the only exception might be the i2c_driver struct which was
copied/modified from an out-of-tree jd9930 driver including that strange
night mode. But nothing more, the rest is a rewrite.

Regards,
Andreas