Re: [PATCH v6 1/4] gpu: nova-core: implement Display for Spec
From: Miguel Ojeda
Date: Sun Nov 09 2025 - 04:48:23 EST
On Sat, Nov 8, 2025 at 12:42 PM Alexandre Courbot <acourbot@xxxxxxxxxx> wrote:
>
> I think this is the correct way to do; `Spec` should be the one to
> decide how it is displayed, and from a maintainability perspective this
> ensures that other sites that will want to print a `Spec` in the future
> will reuse this implementation, instead of either rewriting one
> themselves or having to figure out that there was already an existing
> site and factor it out.
>
> Iow, this code is proactively doing the right thing.
Yes, please, avoid hardcoding inlined display code.
Cheers,
Miguel