Re: [PATCH v2 2/2] iio: adc: Add support for TI ADS1120

[Andy Shevchenko]

On Sun, Nov 09, 2025 at 07:03:56PM +0200, Andy Shevchenko wrote:
> On Sun, Nov 09, 2025 at 07:41:19PM +0530, Ajith Anandhan wrote:

...

> Many are still missing... Please, follow IWYU principle.
> 
> > +#include <linux/bitfield.h>
> > +#include <linux/cleanup.h>
> > +#include <linux/delay.h>
> 
> > +#include <linux/device.h>
> 
> Not see why you need this and not
> 
> dev_printk.h
> device/devres.h

Actually even devres.h is not needed if I did not miss anything.

> instead.
> 
> > +#include <linux/err.h>
> > +#include <linux/module.h>
> > +#include <linux/regmap.h>
> > +#include <linux/spi/spi.h>
> > +#include <linux/unaligned.h>

...

Overall looks much better than previous version.

-- 
With Best Regards,
Andy Shevchenko