Re: [PATCH v1 2/2] dt-bindings: media: i2c: et8ek8: document missing crc as optional property

[Krzysztof Kozlowski]

On Sat, Nov 08, 2025 at 03:32:00PM -0800, Alex Tran wrote:
> Add the optional crc property to the endpoint node for the et8ek8 sensor.
> This property enables CRC checksums for the sensor bus and was added to
> match the new driver support for reading it from the device tree.

We do not add bindings because you want this in the driver. Please
describe the hardware.

> 
> Signed-off-by: Alex Tran <alex.t.tran@xxxxxxxxx>

Your patchser has broken threading. There is no patch #1.

> ---
>  .../devicetree/bindings/media/i2c/toshiba,et8ek8.txt        | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> index 8d8e40c56..5fd30f59b 100644
> --- a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> @@ -30,6 +30,12 @@ Endpoint node mandatory properties
>  - remote-endpoint: A phandle to the bus receiver's endpoint node.
>  
>  
> +Endpoint node optional properties
> +---------------------------------
> +
> +- crc: Enable CRC checksums.

Looks like SW property, so not really suitable for bindings.

Also, no changes to TXT bindings are accepted, so first this would have
to be converted to DT schema.

Best regards,
Krzysztof