Re: [PATCH] ublk: remove unnecessary checks in ublk_check_and_get_req()
From: Chaitanya Kulkarni
Date: Sun Nov 09 2025 - 12:59:00 EST
On 11/8/25 14:17, Caleb Sander Mateos wrote:
> ub = iocb->ki_filp->private_data cannot be NULL, as it's set in
> ublk_ch_open() before it returns succesfully. req->mq_hctx cannot be
> NULL as any inflight ublk request must belong to some queue. And
> req->mq_hctx->driver_data cannot be NULL as it's set to the ublk_queue
> pointer in ublk_init_hctx(). So drop the unnecessary checks.
>
> Signed-off-by: Caleb Sander Mateos<csander@xxxxxxxxxxxxxxx>
> ---
Indeed, Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>
-ck