Re: [PATCH v2 0/6] smb/server: fix return values of smb2_0_server_cmds proc

From: ChenXiaoSong
Date: Sun Nov 09 2025 - 22:01:23 EST


Hi Steve and Namjae,

I have tested the following patches using xfstests and smbtorture, no additional failed test cases were observed in the test results.
- [PATCH v2 0/6] smb/server: fix return values of smb2_0_server_cmds proc
- Patches applied to the ksmbd-for-next-next branch
- [PATCH v5 00/14] smb: move duplicate definitions to common header file

The detailed test results can be found in https://chenxiaosong.com/smb-test/20251109

Thanks,
ChenXiaoSong.

On 10/17/25 6:46 PM, chenxiaosong.chenxiaosong@xxxxxxxxx wrote:
From: ChenXiaoSong <chenxiaosong@xxxxxxxxxx>

These functions should return error code when an error occurs,
then __process_request() will print the error messages.

v1->v2: Update patch #01 #02 due to typos.

v1: https://lore.kernel.org/all/20251017084610.3085644-1-chenxiaosong.chenxiaosong@xxxxxxxxx/

ChenXiaoSong (6):
smb/server: fix return value of smb2_read()
smb/server: fix return value of smb2_notify()
smb/server: fix return value of smb2_query_dir()
smb/server: fix return value of smb2_ioctl()
smb/server: fix return value of smb2_oplock_break()
smb/server: update some misguided comment of smb2_0_server_cmds proc

fs/smb/server/smb2pdu.c | 30 +++++++++++++++++-------------
1 file changed, 17 insertions(+), 13 deletions(-)