Re: [PATCH v4 1/2] iio: trigger: add missing mutex_destroy in iio_trig_release
From: Andy Shevchenko
Date: Mon Nov 10 2025 - 00:26:41 EST
On Mon, Nov 10, 2025 at 11:57:01AM +0800, Ma Ke wrote:
> Add missing mutex_destroy() call in iio_trig_release() to properly
> clean up the mutex initialized in viio_trigger_alloc(). Ensure proper
> resource cleanup and follows kernel practices.
>
> Found by code review.
First of all, the patches should form the series and include a cover letter,
usually it can be done by running
git format-patch -v<X> --cover-letter --base ...
against the branch where changes are located on top of.
Then, here makes sense to add
Suggested-by:: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
The change otherwise LGTM (no need to resend this time),
Reviewed-by:: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
--
With Best Regards,
Andy Shevchenko