Re: [PATCH v2] reset: fix BIT macro reference

[Troy Mitchell]

On Thu, Nov 06, 2025 at 01:00:06AM +0800, Encrow Thorne wrote:
> On Wed, Nov 05, 2025 at 04:51:33PM +0100, Philipp Zabel wrote:
> > On Mi, 2025-11-05 at 23:40 +0800, Encrow Thorne wrote:
> > > RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
> > > include bits.h or bitops.h. This causes compilation errors when
> >                  ^^^^^^^^^^^
> > Troy suggested "or bitops.h" can be dropped.
> > 
> > > including reset.h standalone.
> > > 
> > > Include bits.h to make reset.h self-contained.
> > > 
> > > Suggested-by: Troy Mitchell <troy.mitchell@xxxxxxxxx>
> > > Reviewed-by: Troy Mitchell <troy.mitchell@xxxxxxxxx>
> > > Signed-off-by: Encrow Thorne <jyc0019@xxxxxxxxx>
> > > ---
> > > Changes in v2:
> > > - EDITME: describe what is new in this series revision.
> > > - EDITME: use bulletpoints and terse descriptions.
> > 
> > These should be replaced with a short description of the changes
> > relative to v1.
> > 
> > 
> Sorry for the oversight on my side regarding the “Changes in v2” placeholders.
> Do you recommend I resend a corrected v2 now, or wait and include it in a v3?
> Thanks for your guidance.
Send v3 when you are ready.

          - Troy