Re: [PATCH V3 2/4] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc

From: Sarthak Garg

Date: Mon Nov 10 2025 - 02:06:57 EST


On 10/27/2025 8:02 PM, Krzysztof Kozlowski wrote:
On 26/10/2025 12:17, Sarthak Garg wrote:
Add SD Card host controller for sm8750 soc.

Signed-off-by: Sarthak Garg <sarthak.garg@xxxxxxxxxxxxxxxx>
---
arch/arm64/boot/dts/qcom/sm8750.dtsi | 54 ++++++++++++++++++++++++++++
1 file changed, 54 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index a82d9867c7cb..50e1fa67c093 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -2060,6 +2060,60 @@ ice: crypto@1d88000 {
clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
};
+ sdhc_2: mmc@8804000 {
Completely messed ordering.


Do you mean the property order within the sdhc_2 device tree node ?

What ordering do we need to follow here ?



+ compatible = "qcom,sm8750-sdhci", "qcom,sdhci-msm-v5";
+ reg = <0 0x08804000 0 0x1000>;
Use hex everywhere in reg.

Best regards,
Krzysztof


Sure will update in V2.