Re: [PATCH v18 1/6] dt-bindings: pwm: add IPQ6018 binding

[Uwe Kleine-König]

Hello,

On Wed, Oct 29, 2025 at 10:22:41AM -0500, Bjorn Andersson wrote:
> On Wed, Oct 29, 2025 at 12:36:57PM +0400, George Moussalem via B4 Relay wrote:
> > From: Devi Priya <quic_devipriy@xxxxxxxxxxx>
> > 
> > DT binding for the PWM block in Qualcomm IPQ6018 SoC.
> > [George: added compatibles for IPQ5018, IPQ5332, and IPQ9574]
> > 
> > Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Co-developed-by: Baruch Siach <baruch.siach@xxxxxxxxx>
> > Signed-off-by: Baruch Siach <baruch.siach@xxxxxxxxx>
> > Signed-off-by: Devi Priya <quic_devipriy@xxxxxxxxxxx>
> 
> This is where we expect the [George: ...] comment.
> 
> I'll leave it up to Uwe to determine if he'd like you to resubmit this
> or not though...

Don't resubmit because of that. BTW I only think this type of comment is
important for changes that happen without involving the mailing list. A
typical scenario is when a maintainer does some changes while applying
the patch. In this case I'd say not mentioning the changes you did since
you picked up the series is completely fine.

> > ---
> >  .../devicetree/bindings/pwm/qcom,ipq6018-pwm.yaml  | 51 ++++++++++++++++++++++
> >  1 file changed, 51 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/pwm/qcom,ipq6018-pwm.yaml b/Documentation/devicetree/bindings/pwm/qcom,ipq6018-pwm.yaml
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..ca8e916f03276e93d755d574e2567b0e4b86a8ce
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pwm/qcom,ipq6018-pwm.yaml
> > @@ -0,0 +1,51 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pwm/qcom,ipq6018-pwm.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm IPQ6018 PWM controller
> > +
> > +maintainers:
> > +  - George Moussalem <george.moussalem@xxxxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - qcom,ipq5018-pwm
> > +              - qcom,ipq5332-pwm
> > +              - qcom,ipq9574-pwm
> > +          - const: qcom,ipq6018-pwm
> > +      - const: qcom,ipq6018-pwm
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  "#pwm-cells":
> > +    const: 2

Please use 3 here.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature