Re: [PATCH 2/3] dt-bindings: regulator: Add Fitipower FP9931/JD9930

[Andreas Kemnade]

On Mon, 10 Nov 2025 08:30:41 +0100
Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:

> On 09/11/2025 22:12, Andreas Kemnade wrote:
> >>
> >> You must drop ref. That's the entire point of common unit suffix.
> >>  
> > I tried without it:
> > 
> >   fitipower,tdly-ms:
> >     description:
> >       Power up soft start delay settings tDLY1-4 bitfields in the
> >       POWERON_DELAY register
> >     default: <0 0 0 0>  
> 
> Arrays are in [] (see also some examples of arrays in the example-schema).
> [0, 0, 0, 0]
> 
> And then it should work, but does not which I think is bug in dtschema.
> I think it works fine when you drop the "default:" completely, so please
> do so. I'll take a look at the issue.
>
ok, dropping default makes dtschema happy.

> enum should be in one line, btw.
> 
> Your patchset has also blank line warnings.
I fixed the ones shown by

checkpatch.pl --strict

are there any more I am missing?

Regards,
Andreas