Re: [PATCH 18/24] arm64: dts: qcom: glymur: Add PMIC glink node

[Kamal Wadhwa]

Hi Konrad,

On Mon, Nov 3, 2025 at 3:56 PM Kamal Wadhwa
<kamal.wadhwa@xxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Oct 08, 2025 at 05:25:39PM +0530, Pankaj Patil wrote:
> > On 9/25/2025 4:02 PM, Konrad Dybcio wrote:
> > > On 9/25/25 8:32 AM, Pankaj Patil wrote:
> > >> From: Kamal Wadhwa <kamal.wadhwa@xxxxxxxxxxxxxxxx>
> > >>
> > >> Add the pmic glink node with connectors.
> > >>
> > >> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@xxxxxxxxxxxxxxxx>
> > >> Signed-off-by: Pankaj Patil <pankaj.patil@xxxxxxxxxxxxxxxx>
> > >> ---
> > >>  arch/arm64/boot/dts/qcom/glymur-crd.dts | 28 ++++++++++++++++++++++++++++
> > >>  1 file changed, 28 insertions(+)
> > >>
> > >> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dts b/arch/arm64/boot/dts/qcom/glymur-crd.dts
> > >> index b04c0ed28468620673237fffb4013adacc7ef7ba..3f94bdf8b3ccfdff182005d67b8b3f84f956a430 100644
> > >> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dts
> > >> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dts
> > >> @@ -79,6 +79,34 @@ key-volume-up {
> > >>                    wakeup-source;
> > >>            };
> > >>    };
> > >> +
> > >> +  pmic-glink {
> > >> +          compatible = "qcom,sm8550-pmic-glink",
> > > You *must* include a glymur compatible
> > >
> > >> +                       "qcom,pmic-glink";
> > > Are you sure this is still compatible with 8550 after this
> > > series landed?
> > >
> > > https://lore.kernel.org/linux-arm-msm/20250917-qcom_battmgr_update-v5-0-270ade9ffe13@xxxxxxxxxxxxxxxx/
>
> Sorry for late reply, earlier when we were sending this series our understanding
> was that we only need to support for usb shell, and anyway the device was on the
> debug board so this feature(battery/charging) was not tested.
>
> However, after testing i found that the power supplies are getting registered
> properly however the data is not coming as expected. we are working to fix this
> internally from the firmware guys.

As you had asked,  i was able to check with this patch (and firmware fixes)
https://lore.kernel.org/linux-arm-msm/20250917-qcom_battmgr_update-v5-0-270ade9ffe13@xxxxxxxxxxxxxxxx/

The qcom_battmngr driver is working fine with this patch included as well.
(though i faced some conflicts which i had to manually fix when
pulling this patch on latest linux-next tag)