Re: [PATCH v18 1/6] dt-bindings: pwm: add IPQ6018 binding

[Uwe Kleine-König]

Hello George,

On Mon, Nov 10, 2025 at 03:41:49PM +0400, George Moussalem wrote:
> On 11/10/25 15:32, Uwe Kleine-König wrote:
> >>> +  "#pwm-cells":
> >>> +    const: 2
> > 
> > Please use 3 here.
> 
> The driver doesn't support polarity and I don't know whether the HW even
> supports it. Hence, I kept it as 2 as originally submitted by qcom
> (Devi). I don't have access to the datasheets. Would you like me to
> resubmit a new version anyways or keep as is?

I want all new drivers use 3 pwm-cells for consistency even if the
hardware doesn't support the (currently) only flag. Additionally this
simplifies things like pwm nexus nodes (see
e71e46a6f19c46b38983bebde8bfac1c04968fdf).

So yes, please change to 3.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature