Re: [PATCH] virtio: fix kernel-doc for mapping/free_coherent functions

From: Chaitanya Kulkarni
Date: Mon Nov 10 2025 - 15:47:27 EST


On 11/10/25 12:29, Kriish Sharma wrote:
> Documentation build reported:
>
> WARNING: ./drivers/virtio/virtio_ring.c:3174 function parameter 'vaddr' not described in 'virtqueue_map_free_coherent'
> WARNING: ./drivers/virtio/virtio_ring.c:3308 expecting prototype for virtqueue_mapping_error(). Prototype was for virtqueue_map_mapping_error() instead
>
> The kernel-doc block for virtqueue_map_free_coherent() omitted the @vaddr parameter, and
> the kernel-doc header for virtqueue_map_mapping_error() used the wrong function name
> (virtqueue_mapping_error) instead of the actual function name.
>
> This change updates:
>
> - the function name in the comment to virtqueue_map_mapping_error()
> - adds the missing @vaddr description in the comment for virtqueue_map_free_coherent()
>
> Fixes: b41cb3bcf67f ("virtio: rename dma helpers")
> Signed-off-by: Kriish Sharma<kriish.sharma2006@xxxxxxxxx>



Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

-ck