Re: [PATCH] mips: Use generic endianness macros instead of MIPS-specific ones
From: Nathan Chancellor
Date: Mon Nov 10 2025 - 16:09:48 EST
On Mon, Nov 10, 2025 at 01:34:19AM +0000, Maciej W. Rozycki wrote:
> Also please don't review changes based on assumptions, "I assume GCC
> does[...]" means that you just don't know (and it's trivial to check).
Yes, that is totally valid. I hastily reviewed this when I should have
taken the time to check but I did not have a MIPS cross compiler
available locally to test and I forgot that I can use Godbolt for that
test. I'll be more mindful of that in the future (or at least being
clear that I did not actually check but it should be verified before the
change is merged without providing a tag).
> target macros. Since our current GCC requirement is 5.1 it will be fine
Just an FYI, the minimum GCC version is 8.1 since commit 118c40b7b503
("kbuild: require gcc-8 and binutils-2.30") in 6.16.
Cheers,
Nathan