re: [PATCH] spi: hisi-kunpeng: Fixed the wrong debugfs node name in hisi_spi debugfs initialization
From: liudingyuan
Date: Mon Nov 10 2025 - 21:06:42 EST
> In hisi_spi_debugfs_init, spi controller pointer is calculated by container_of macro, and the member is hs->dev. But the host pointer cannot be calculated offset directly by this, because hs->dev points to the device in platform device(pdev->dev), and it is > the host->dev.parent points to the pdev->dev, which is set in __spi_alloc_controller.
>
>In this patch, this issues is fixed by getting the spi_controller data from pdev->dev->driver_data directly, driver_data points to the spi controller data in the probe stage.
>
> Signed-off-by: Devyn Liu <liudingyuan@xxxxxxxxxxxxxx>
> ---
> drivers/spi/spi-hisi-kunpeng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-hisi-kunpeng.c b/drivers/spi/spi-hisi-kunpeng.c index dadf558dd9c0..7458a4bc0856 100644
>--- a/drivers/spi/spi-hisi-kunpeng.c
> +++ b/drivers/spi/spi-hisi-kunpeng.c
> @@ -164,7 +164,7 @@ static int hisi_spi_debugfs_init(struct hisi_spi *hs)
>
> struct spi_controller *host;
>
> - host = container_of(hs->dev, struct spi_controller, dev);
> + host = hs->dev->driver_data;
> snprintf(name, 32, "hisi_spi%d", host->bus_num);
> hs->debugfs = debugfs_create_dir(name, NULL);
> if (IS_ERR(hs->debugfs))
> --
> 2.33.0
Gentle ping on this patch.