Re: [PATCH net-next v06 2/5] hinic3: Add PF management interfaces

From: Jakub Kicinski
Date: Mon Nov 10 2025 - 21:48:00 EST


On Sat, 8 Nov 2025 14:41:37 +0800 Fan Gong wrote:
> + struct semaphore port_state_sem;

You seem to init this semaphore to 1, could you not use a mutex?
Mutexes are faster and have better debugging. If you have a reason
for a semaphore please document.