Re: [PATCH -next 3/3] cpuset: remove need_rebuild_sched_domains

[Chen Ridong]

On 2025/11/11 12:37, Waiman Long wrote:
> 
> On 11/9/25 8:52 PM, Chen Ridong wrote:
>> From: Chen Ridong <chenridong@xxxxxxxxxx>
>>
>> Previously, update_cpumasks_hier() used need_rebuild_sched_domains to
>> decide whether to invoke rebuild_sched_domains_locked(). Now that
>> rebuild_sched_domains_locked() only sets force_rebuild, the flag is
>> redundant. Hence, remove it.
>>
>> Signed-off-by: Chen Ridong <chenridong@xxxxxxxxxx>
>> ---
>>   kernel/cgroup/cpuset.c | 6 +-----
>>   1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
>> index c357bfb69fe2..22084d8bdc3f 100644
>> --- a/kernel/cgroup/cpuset.c
>> +++ b/kernel/cgroup/cpuset.c
>> @@ -2184,7 +2184,6 @@ static void update_cpumasks_hier(struct cpuset *cs, struct tmpmasks *tmp,
>>   {
>>       struct cpuset *cp;
>>       struct cgroup_subsys_state *pos_css;
>> -    bool need_rebuild_sched_domains = false;
>>       int old_prs, new_prs;
>>         rcu_read_lock();
>> @@ -2348,15 +2347,12 @@ static void update_cpumasks_hier(struct cpuset *cs, struct tmpmasks *tmp,
>>           if (!cpumask_empty(cp->cpus_allowed) &&
>>               is_sched_load_balance(cp) &&
>>              (!cpuset_v2() || is_partition_valid(cp)))
>> -            need_rebuild_sched_domains = true;
>> +            cpuset_force_rebuild();
>>             rcu_read_lock();
>>           css_put(&cp->css);
>>       }
>>       rcu_read_unlock();
>> -
>> -    if (need_rebuild_sched_domains)
>> -        cpuset_force_rebuild();
>>   }
>>     /**
> Reviewed-by: Waiman Long <longman@xxxxxxxxxx>
> 

Thanks.

-- 
Best regards,
Ridong