Re: [PATCH v1 0/5] Remove NO_AUXTRACE build option
From: Namhyung Kim
Date: Tue Nov 11 2025 - 01:22:54 EST
Hi Ian,
On Sun, Nov 09, 2025 at 05:31:47PM -0800, Ian Rogers wrote:
> Switch the __get_cpuid feature for intel-pt to use the provided cpuid
> function in perf, this removes the need for NO_AUXTRACE when the
> feature detection fails. Remove the now unnecessary feature
> detection. Remove NO_AUXTRACE as it just builds a more broken version
Can you please elaborate what the broken part is?
Thanks,
Namhyung
> of perf and isn't guarding dependencies on any libraries, etc. Clean
> up headers files for auxtrace.h.
>
> This was prompted by needing to make a v2 patch set of:
> https://lore.kernel.org/lkml/20251107170712.2302714-1-irogers@xxxxxxxxxx/
> due to a broken NO_AUXTRACE configuration.
>
> Ian Rogers (5):
> perf intel-pt: Use the perf provided "cpuid.h"
> perf build: Don't add NO_AUXTRACE if missing feature-get_cpuid
> tool build: Remove __get_cpuid feature test
> perf build: Remove NO_AUXTRACE build option
> perf auxtrace: Remove errno.h from auxtrace.h and fix transitive
> dependencies
>
> tools/build/Makefile.feature | 2 -
> tools/build/feature/Makefile | 4 -
> tools/build/feature/test-all.c | 5 -
> tools/build/feature/test-get_cpuid.c | 8 -
> tools/perf/Documentation/perf-check.txt | 1 -
> tools/perf/Makefile.config | 13 --
> tools/perf/Makefile.perf | 2 -
> tools/perf/arch/arm/annotate/instructions.c | 1 +
> tools/perf/arch/arm/util/Build | 2 +-
> tools/perf/arch/arm/util/auxtrace.c | 1 +
> tools/perf/arch/arm/util/pmu.c | 2 -
> tools/perf/arch/arm64/annotate/instructions.c | 1 +
> tools/perf/arch/arm64/util/Build | 19 +-
> tools/perf/arch/arm64/util/arm-spe.c | 1 +
> tools/perf/arch/arm64/util/hisi-ptt.c | 1 +
> tools/perf/arch/powerpc/util/Build | 2 +-
> tools/perf/arch/powerpc/util/auxtrace.c | 2 +-
> tools/perf/arch/s390/util/Build | 2 +-
> tools/perf/arch/s390/util/auxtrace.c | 1 +
> tools/perf/arch/x86/tests/Build | 4 +-
> tools/perf/arch/x86/tests/arch-tests.c | 4 -
> tools/perf/arch/x86/tests/intel-pt-test.c | 6 +-
> tools/perf/arch/x86/tests/topdown.c | 1 +
> tools/perf/arch/x86/util/Build | 6 +-
> tools/perf/arch/x86/util/intel-pt.c | 4 +-
> tools/perf/arch/x86/util/pmu.c | 2 -
> tools/perf/arch/x86/util/topdown.c | 1 +
> tools/perf/bench/evlist-open-close.c | 1 +
> tools/perf/bench/futex.c | 1 +
> tools/perf/bench/pmu-scan.c | 1 +
> tools/perf/bench/synthesize.c | 1 +
> tools/perf/builtin-check.c | 1 -
> tools/perf/builtin-inject.c | 15 --
> tools/perf/builtin-mem.c | 1 +
> tools/perf/builtin-record.c | 36 ---
> tools/perf/builtin-script.c | 12 -
> tools/perf/tests/hwmon_pmu.c | 1 +
> tools/perf/tests/make | 4 +-
> tools/perf/tests/parse-metric.c | 1 +
> tools/perf/tests/pfm.c | 1 +
> tools/perf/ui/hist.c | 1 +
> tools/perf/util/Build | 24 +-
> tools/perf/util/annotate-data.c | 2 +-
> tools/perf/util/arm-spe-decoder/Build | 2 +-
> tools/perf/util/auxtrace.h | 221 +-----------------
> tools/perf/util/bpf-filter.h | 2 +
> tools/perf/util/bpf-trace-summary.c | 1 +
> tools/perf/util/bpf_counter_cgroup.c | 1 +
> tools/perf/util/bpf_ftrace.c | 3 +-
> tools/perf/util/bpf_map.c | 1 +
> tools/perf/util/cgroup.c | 1 +
> tools/perf/util/cs-etm-decoder/Build | 2 +-
> tools/perf/util/drm_pmu.c | 1 +
> tools/perf/util/evswitch.c | 1 +
> tools/perf/util/hisi-ptt-decoder/Build | 2 +-
> tools/perf/util/intel-pt-decoder/Build | 8 +-
> tools/perf/util/intel-tpebs.c | 1 +
> tools/perf/util/kvm-stat.h | 1 +
> tools/perf/util/mmap.c | 1 +
> tools/perf/util/pfm.c | 1 +
> tools/perf/util/powerpc-vpadtl.c | 1 +
> tools/perf/util/stat-shadow.c | 1 +
> tools/perf/util/synthetic-events.h | 15 --
> 63 files changed, 77 insertions(+), 391 deletions(-)
> delete mode 100644 tools/build/feature/test-get_cpuid.c
>
> --
> 2.51.2.1041.gc1ab5b90ca-goog
>