Re: [PATCH 1/2] dt-bindings: HID: i2c-hid: elan: Introduce FocalTech FT8112

[Pin-yen Lin]

Hi Daniel,

On Tue, Nov 11, 2025 at 9:34 AM
<daniel_peng@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> From: Daniel Peng <Daniel_Peng@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
> The FocalTech FT8112 touch screen chip same as Ilitek ili2901 controller
> has a reset gpio. The difference is that they have different
> post_gpio_reset_on_delay_ms.
> FocalTech FT8112 also uses 3.3V power supply.
>
> Signed-off-by: Daniel Peng <Daniel_Peng@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>
>  .../bindings/input/focaltech,ft8112.yaml      | 66 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  2 files changed, 67 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
>
> diff --git a/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml b/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
> new file mode 100644
> index 000000000000..391825b24fcb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/focaltech,ft8112.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: FocalTech FT8112 touchscreen controller
> +
> +maintainers:
> +  - Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

List yourself as the maintainer of this binding file instead of the
subsystem maintainer.
> +
> +description:
> +  Supports the FocalTech FT8112 touchscreen controller.
> +  This touchscreen controller uses the i2c-hid protocol with a reset GPIO.
> +
> +allOf:
> +  - $ref: /schemas/input/touchscreen/touchscreen.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - focaltech,ft8112
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  panel: true
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +  vcc33-supply: true
> +
> +  vccio-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - vcc33-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      touchscreen@38 {
> +        compatible = "focaltech,ft8112";
> +        reg = <0x38>;
> +
> +        interrupt-parent = <&pio>;
> +        interrupts = <15 IRQ_TYPE_LEVEL_LOW>>;

You have an extra '>' here. This should be caught by `make
dt_binding_check`. Please check [1] and [2], and make sure the patches
are tested before you send them out.

[1]: https://www.kernel.org/doc/Documentation/devicetree/writing-schema.md
[2]: https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> +
> +        reset-gpios = <&pio 126 GPIO_ACTIVE_LOW>;
> +        vcc33-supply = <&pp3300_tchscr_x>;
> +      };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ddecf1ef3bed..69f54515fe98 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12326,6 +12326,7 @@ T:      git git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
>  F:     Documentation/devicetree/bindings/input/
>  F:     Documentation/devicetree/bindings/serio/
>  F:     Documentation/input/
> +F:     drivers/hid/

Why did you add this?

>  F:     drivers/input/
>  F:     include/dt-bindings/input/
>  F:     include/linux/gameport.h

Regards,
Pin-yen