Re: [EXTERNAL] Re: [PATCH v1 2/2] ASoC: dt-bindings: ti,tas2781: Add TAS2568/5806M/5806MD/5830 support

From: Xu, Baojun
Date: Tue Nov 11 2025 - 03:21:28 EST



________________________________________
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: 11 November 2025 15:17
> To: Xu, Baojun
> Cc: broonie@xxxxxxxxxx; tiwai@xxxxxxx; andriy.shevchenko@xxxxxxxxxxxxxxx; 13916275206@xxxxxxx; Ding, Shenghao; linux-sound@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; lgirdwood@xxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Yi, Ken; Lo, Henry; Chen, Robin; Wang, Will; jim.shil@xxxxxxxxxxx; toastcheng@xxxxxxxxxx; chinkaiting@xxxxxxxxxx
> Subject: Re: [EXTERNAL] Re: [PATCH v1 2/2] ASoC: dt-bindings: ti,tas2781: Add TAS2568/5806M/5806MD/5830 support
> >
> > Hi Krzysztof,
> >
> > Thanks for your review.
> > Do you mean I need to add an rst file in Documentation\sound\codecs?
>
> Where anything like that is explained in the docs I linked? Do you
> understand what patch I commented on and what documented I linked?
>
Hi Krzysztof,

Thanks for your review.
>From your link, it write:
5) The Documentation/ portion of the patch should come in the series before
the code implementing the binding.

Do you mean I need move compatible to above, like below:

properties:
compatible:
- enum:
- ti,tas2020
- ti,tas2118
- ti,tas2120
... ...

> Best regards,
> Krzysztof
>
>
Best Regards
Jim