Re: [PATCH] efi: stmm: fix kernel-doc "bad line" warnings

[Ilias Apalodimas]

Hi Randy

On Tue, 11 Nov 2025 at 08:02, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> Add a beginning " *" to each line to avoid kernel-doc warnings:
>
> Warning: drivers/firmware/efi/stmm/mm_communication.h:34 bad line:
> Warning: drivers/firmware/efi/stmm/mm_communication.h:113 bad line:
> Warning: drivers/firmware/efi/stmm/mm_communication.h:130 bad line:
>
> Fixes: c44b6be62e8d ("efi: Add tee-based EFI variable driver")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Is the fixes tag necessary here?
Acked-by: Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>

Thanks
/Ilias
> ---
> Cc: Ard Biesheuvel <ardb@xxxxxxxxxx>
> Cc: linux-efi@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
> Cc: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>
> ---
>  drivers/firmware/efi/stmm/mm_communication.h |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- linux-next-20251107.orig/drivers/firmware/efi/stmm/mm_communication.h
> +++ linux-next-20251107/drivers/firmware/efi/stmm/mm_communication.h
> @@ -32,7 +32,7 @@
>
>  /**
>   * struct efi_mm_communicate_header - Header used for SMM variable communication
> -
> + *
>   * @header_guid:  header use for disambiguation of content
>   * @message_len:  length of the message. Does not include the size of the
>   *                header
> @@ -111,7 +111,7 @@ struct efi_mm_communicate_header {
>
>  /**
>   * struct smm_variable_communicate_header - Used for SMM variable communication
> -
> + *
>   * @function:     function to call in Smm.
>   * @ret_status:   return status
>   * @data:         payload
> @@ -128,7 +128,7 @@ struct smm_variable_communicate_header {
>  /**
>   * struct smm_variable_access - Used to communicate with StMM by
>   *                              SetVariable and GetVariable.
> -
> + *
>   * @guid:         vendor GUID
>   * @data_size:    size of EFI variable data
>   * @name_size:    size of EFI name
>