Re: [PATCH v4 1/4] dt-bindings: clock: google,gs101-clock: add samsung,sysreg property as required

[André Draszik]

Hi Peter,

On Mon, 2025-11-10 at 14:21 +0000, Peter Griffin wrote:
> [...]
> 
> diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml b/Documentation/devicetree/bindings/clock/google,gs101-
> clock.yaml
> index 31e106ef913dead9a038b3b6d8b43b950587f6aa..5ce5ba523110af3a2a7740b8ba28e2271c76bddb 100644
> --- a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> @@ -52,6 +52,11 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  samsung,sysreg:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Phandle to system registers interface.
> +
>  required:
>    - compatible
>    - "#clock-cells"
> @@ -166,6 +171,22 @@ allOf:
>              - const: bus
>              - const: ip
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - google,gs101-cmu-apm
> +              - google,gs101-cmu-misc
> +              - google,gs101-hsi0

Shouldn't this be google,gs101-cmu-hsi0?

> +              - google,gs101-cmu-hsi2
> +              - google,gs101-cmu-peric0
> +              - google,gs101-cmu-peric1
> +
> +    then:
> +      required:
> +        - samsung,sysreg

The above still allows (but doesn't enforce) samsung,sysreg on cmu-top.

Maybe it'd be better to invert the test, as cmu-top is the only
outlier, and then the binding doesn't need to be updated when more
CMUs are added (untested):

  - if:
      properties:
        compatible:
          contains:
            const: google,gs101-cmu-top

    then:
      required:
        - samsung,sysreg

    else:
      properties:
        samsung,sysreg: false


Cheers,
Andre'