Re: [PATCH net-next v3 3/3] net: phy: mscc: Add support for PHY LED control
From: Lad, Prabhakar
Date: Tue Nov 11 2025 - 05:06:14 EST
Hi Parthiban,
Thank you for the review.
On Tue, Nov 11, 2025 at 9:54 AM <Parthiban.Veerasooran@xxxxxxxxxxxxx> wrote:
>
> On 11/11/25 2:40 pm, Prabhakar wrote:
> > +static int vsc85xx_led_combine_disable_set(struct phy_device *phydev,
> > + u8 led_num, bool combine_disable)
> > +{
> > + u16 mask = LED_COMBINE_DIS_MASK(led_num);
> > + u16 val = LED_COMBINE_DIS(led_num, combine_disable);
> Follow reverse xmas tree variable declaration style.
>
Sure, will do.
Cheers,
Prabhakar