Re: [PATCH RFC] dt-bindings: arm: keystone: add boot_* mailboxes

[Krzysztof Kozlowski]

On 11/11/2025 11:37, Anshul Dalal wrote:
> The bootloader on K3 devices makes use of mailboxes as per the ROM spec
> which might be different than one's available to the kernel (firmware
> spec).

Why is this RFC? You don't expect review?

> 
> Therefore, this patch adds the missing mailbox entries to the DT binding
> to represent the mailboxes exposed by the hardware during boot for the
> purpose of loading the firmware.
> 
> Signed-off-by: Anshul Dalal <anshuld@xxxxxx>
> ---
>  Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index 25a2b42105e541cb3c8ad12a0dfec1af038fa907..b5f48647a0f09bb930f052ea0f84a78525c925eb 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> @@ -51,15 +51,23 @@ properties:
>      minItems: 1
>  
>    mbox-names:
> +    minItems: 2
> +    maxItems: 6
>      description: |
>        Specifies the mailboxes used to communicate with TI-SCI Controller
> -      made available from TI-SCI controller.
> +      made available from TI-SCI controller. All boot_* mailboxes are used by
> +      the first stage bootloader to load firmware for the device.

Description does not go to mbox-names, but to mboxes.

>      items:
>        - const: rx
>        - const: tx
> +      - const: notify
> +      - const: boot_rx
> +      - const: boot_tx
> +      - const: boot_notify
>  
>    mboxes:
>      minItems: 2
> +    maxItems: 6

You need to list the items instead.

>  
>    ti,host-id:
>      $ref: /schemas/types.yaml#/definitions/uint32

You should update the example so it will be complete.

Best regards,
Krzysztof