Re: [PATCH v4 4/8] ACPI: CPPC: add APIs and sysfs interface for min/max_perf

[Sumit Gupta]

On 08/11/25 01:38, Rafael J. Wysocki wrote:
....
> > > > > Warning: drivers/cpufreq/cppc_cpufreq.c:954 function parameter 'policy' not described in 'show_min_perf'
> > > > > Warning: drivers/cpufreq/cppc_cpufreq.c:954 function parameter 'buf' not described in 'show_min_perf'
> > > > > Warning: drivers/cpufreq/cppc_cpufreq.c:976 function parameter 'policy' not described in 'store_min_perf'
> > > > > Warning: drivers/cpufreq/cppc_cpufreq.c:976 function parameter 'buf' not described in 'store_min_perf'
> > > > > Warning: drivers/cpufreq/cppc_cpufreq.c:976 function parameter 'count' not described in 'store_min_perf'
> > > > > Warning: drivers/cpufreq/cppc_cpufreq.c:1003 function parameter 'policy' not described in 'show_max_perf'
> > > > > Warning: drivers/cpufreq/cppc_cpufreq.c:1003 function parameter 'buf' not described in 'show_max_perf'
> > > > > Warning: drivers/cpufreq/cppc_cpufreq.c:1025 function parameter 'policy' not described in 'store_max_perf'
> > > > > Warning: drivers/cpufreq/cppc_cpufreq.c:1025 function parameter 'buf' not described in 'store_max_perf'
> > > > > Warning: drivers/cpufreq/cppc_cpufreq.c:1025 function parameter 'count' not described in 'store_max_perf'
> > > --
> > > 0-DAY CI Kernel Test Service
> > > https://github.com/intel/lkp-tests/wiki
> >
> > Thank you for the report.
> > Below change to comments seem to be fixing this warning.
> So can you please send a new version of this patch with the changes
> below folded in?

Sure.


> > -------------------------------------------------------
> >     /**
> >     * show_min_perf - Show minimum performance as frequency (kHz)
> > + * @policy: cpufreq policy
> > + * @buf: buffer to write the frequency value to
> >     *
> >     * Reads the MIN_PERF register and converts the performance value to
> >     * frequency (kHz) for user-space consumption.
> > @@ -1117,6 +1119,9 @@ static ssize_t show_min_perf(struct cpufreq_policy
> > *policy, char *buf)
> >
> >    /**
> >     * store_min_perf - Set minimum performance from frequency (kHz)
> > + * @policy: cpufreq policy
> > + * @buf: buffer to write the frequency value to
> > + * @count: size of @buf
> >     *
> >     * Converts the user-provided frequency (kHz) to a performance value
> >     * and writes it to the MIN_PERF register.
> > @@ -1144,6 +1149,8 @@ static ssize_t store_min_perf(struct
> > cpufreq_policy *policy, const char *buf, si
> >
> >    /**
> >     * show_max_perf - Show maximum performance as frequency (kHz)
> > + * @policy: cpufreq policy
> > + * @buf: buffer to write the frequency value to
> >     *
> >     * Reads the MAX_PERF register and converts the performance value to
> >     * frequency (kHz) for user-space consumption.
> > @@ -1166,6 +1173,9 @@ static ssize_t show_max_perf(struct cpufreq_policy
> > *policy, char *buf)
> >
> >    /**
> >     * store_max_perf - Set maximum performance from frequency (kHz)
> > + * @policy: cpufreq policy
> > + * @buf: buffer to write the frequency value to
> > + * @count: size of @buf
> > -------------------------------------------------------
> As for the whole series, I generally need ARM folks to review it and
> tell me that it is fine.
>
> Thanks!

Will wait if ARM folks have any new comment and then re-spin next version?

Thank you,
Sumit Gupta