Re: [PATCH v4 2/2] arm64: dts: add support for NXP i.MX8MP FRDM board
From: Fabio Estevam
Date: Tue Nov 11 2025 - 06:53:13 EST
Hi Daniel,
On Tue, Nov 11, 2025 at 5:45 AM Daniel Baluta <daniel.baluta@xxxxxxxxx> wrote:
> In addition to that, Rogerio please read:
>
> https://docs.kernel.org/process/submitting-patches.html
>
> At this moment I think you should keep the original author of the
> patch.
Right, but NXP makes a total mess with authorship.
Please see this version from February that states the original author
as Xiaofeng Wei <xiaofeng.wei@xxxxxxx>:
https://github.com/nxp-imx-support/meta-imx-frdm/blob/lf-6.6.36-2.1.0/meta-imx-bsp/recipes-kernel/linux/linux-imx/0023-arm64-dts-Add-i.MX8MP-FRDM-board-support.patch
Then this one from July states the original author as Joseph Guo
<qijian.guo@xxxxxxx> and it also has:
Signed-off-by: Steven Yang <steven.yang@xxxxxxx>
Signed-off-by: Lei Xu <lei.xu@xxxxxxx>
https://github.com/nxp-imx/linux-imx/commit/fd8010b46bb00344fa519c73b643fad71da5887b
How are we supposed to know the correct authorship tags from the NXP
commit, then?
> Then mark your contribution as follows. If you just picked the patches
> tested them and made minor modifictions only add your S-o-b
>
> e.g
>
> Signed-off-by: Xiaofeng Wei <xiaofeng.wei@xxxxxxx>
> Signed-off-by: Rogerio Pimentel <rpimentel.silva@xxxxxxxxx>
>
> If you made significant changes add your C-d-b like this:
>
> Signed-off-by: Xiaofeng Wei <xiaofeng.wei@xxxxxxx>
> Co-developed-by: Rogerio Pimentel <rpimentel.silva@xxxxxxxxx>
> Signed-off-by: Rogerio Pimentel <rpimentel.silva@xxxxxxxxx>
Rogerio's changes are significant as the dt-schema passes now.
The NXP commit has all the dt-schema warnings found in downstream BSPs.
For example, it makes the old mistake of describing:
spidev1: spi@0 {
reg = <0>;
compatible = "lwn,bk4";
spi-max-frequency = <1000000>;
};
Which is totally wrong.