Re: [PATCH] power: supply: ab8500_chargalg: improve kernel-doc

[Linus Walleij]

On Tue, Nov 11, 2025 at 7:00 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:

> Correct "bad line" warnings and add descriptions for missing entries
> to avoid these warnings:
>
> ab8500_chargalg.c:173: warning: bad line:  is set
> ab8500_chargalg.c:179: warning: bad line:  increased
> ab8500_chargalg.c:247: warning: Function parameter or struct member
>  't_hyst_norm' not described in 'ab8500_chargalg'
> ab8500_chargalg.c:247: warning: Function parameter or struct member
>  't_hyst_lowhigh' not described in 'ab8500_chargalg'
> ab8500_chargalg.c:247: warning: Function parameter or struct member
>  'ccm' not described in 'ab8500_chargalg'
> ab8500_chargalg.c:247: warning: Function parameter or struct member
>  'ac_chg' not described in 'ab8500_chargalg'
> ab8500_chargalg.c:247: warning: Function parameter or struct member
>  'usb_chg' not described in 'ab8500_chargalg'
> ab8500_chargalg.c:308: warning: Function parameter or struct member
>  'state' not described in 'ab8500_chargalg_state_to'
> ab8500_chargalg.c:773: warning: Function parameter or struct member
>  'di' not described in 'ab8500_chargalg_chg_curr_maxim'
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thanks for fixing this Randy!

Yours,
Linus Walleij