RE: [PATCH 2/3] dt-bindings: mfd: Add Realtek ISO system controller

[Eleanor Lin [林祐君]]

Hi Krzysztof,

Sorry for the delay in responding to you.

> On 05/11/2025 11:44, Yu-Chun Lin wrote:
> > Add DT binding schema for Realtek system controller.
> >
> > Signed-off-by: Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>
> > ---
> >  .../bindings/mfd/realtek,iso-system.yaml      | 65
> +++++++++++++++++++
> >  1 file changed, 65 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml
> > b/Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml
> > new file mode 100644
> > index 000000000000..6fbdedd3ee5b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml
> > @@ -0,0 +1,65 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mfd/realtek,iso-system.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Realtek ISO System Controller
> > +
> > +description: |
> 
> 
> Do not need '|' unless you need to preserve formatting.
> 

I will remove it in V2.

> > +  The Realtek ISO System Controller is a register area that contains
> > + miscellaneous system registers for the SoC and serves as a parent
> > + node  for other functions.
> > +
> > +maintainers:
> > +  - James Tai <james.tai@xxxxxxxxxxx>
> > +  - Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - realtek,iso-system
> 
> No clue what is "iso system", neither commit msg, nor title nor description
> explain me that. Please add first bindings for the iso soc or if this is not soc,
> then use only soc-specific compatibles (see writing bindings doc).
> 

I will rename 'realtek,misc' for clarity.

> > +      - const: syscon
> > +      - const: simple-mfd
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  ranges:
> > +    maxItems: 1
> > +
> > +  '#address-cells':
> > +    const: 1
> > +
> > +  '#size-cells':
> > +    const: 1
> > +
> > +  reg-io-width:
> > +    const: 4
> > +
> > +patternProperties:
> > +  "^.*@[0-9a-f]+$":
> > +    type: object
> > +    description: Catch-all for other sub-devices in the ISO area.
> 
> Nope, sorry. Define exact children. All of them.
> 

Got it. I will explicitly define child for V2.

> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - ranges
> > +  - '#address-cells'
> > +  - '#size-cells'
> > +  - reg-io-width
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    iso: syscon@7000 {
> 
> Drop label.
> 

I will remove it in V2.

> > +        compatible = "realtek,iso-system", "syscon", "simple-mfd";
> > +        reg = <0x7000 0x1000>;
> > +        ranges = <0x0 0x7000 0x1000>;
> > +        reg-io-width = <4>;
> > +        #address-cells = <1>;
> > +        #size-cells = <1>;
> 
> No children here, so drop simple-mfd and all these fake child stuff.
>
I will show its child in example in V2.
> 
> Best regards,
> Krzysztof