Re: [PATCH 06/13] mfd: sec-irq: add support for creating multiple IRQ chips

[Kaustabh Chakraborty]

On 2025-11-14 11:55, André Draszik wrote:
> On Fri, 2025-11-14 at 08:50 +0100, Alexandre Belloni wrote:
>> On 14/11/2025 00:35:07+0530, Kaustabh Chakraborty wrote:
>> > The current state of the driver only allows creating only one IRQ chip
>> > per PMIC. On some PMICs, such as Samsung's S2MU005, there are multiple
>> > interrupt blocks, for which the current implementation stands insufficient.
>> > 
>> > Add support for creating multiple IRQ chips for a PMIC. Every IRQ chip is
>> > given it's own index, which is used by sub-device drivers to request IRQs.
>> > 
>> > A macro is defined which states the maximum number of chips supported.
>> > It's set to 1 as currently, no PMIC requires more than one IRQ chip. The
>> > value must be changed accordingly on adding new PMICs requiring multiple
>> > IRQ chips.
>> > 
>> > Moreover, adjust the s5m RTC driver to initialize IRQs with the
>> > appropriate IRQ chip index.
>> > 
>> > Signed-off-by: Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx>
>> Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
>> 
>> > ---
>> >  drivers/mfd/sec-irq.c            | 163 +++++++++++++++++++++++----------------
>> >  drivers/rtc/rtc-s5m.c            |  15 +++-
>> >  include/linux/mfd/samsung/core.h |   5 +-
>> >  include/linux/mfd/samsung/irq.h  |  14 ++++
>> >  4 files changed, 127 insertions(+), 70 deletions(-)
> 
> Your patch reminded me to finally send
> https://lore.kernel.org/all/20251114-s5m-alarm-v1-0-c9b3bebae65f@xxxxxxxxxx/
> 
> If applied first, you wouldn't need to touch rtc-s5m.c I believe.

Oo, this cleans things up greatly!

> 
> Equally, I can rebase mine on top of yours - no strong feelings.

I will wait for your series to be applied. Your series is much shorter,
so wouldn't hold that back for this. :)

> 
> Cheers,
> Andre'