Re: [PATCH 2/2] dt-bindings: arm: qcom: rubikpi3: document rubikpi3 board binding
From: Krzysztof Kozlowski
Date: Sat Nov 15 2025 - 07:26:33 EST
On Sat, Nov 15, 2025 at 12:34:16AM +0800, Hongyang Zhao wrote:
> Add binding for the Thundercomm RUBIK Pi 3 board,
> which is based on the Qualcomm Dragonwing QCS6490 SoC.
>
> Signed-off-by: Hongyang Zhao <hongyang.zhao@xxxxxxxxxxxxxxx>
> Reviewed-by: Roger Shimizu <rosh@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
A nit, subject: drop second/last, redundant "binding". The
"dt-bindings" prefix is already stating that these are bindings. And
that this is documentation...
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Please organize the patch documenting the compatible (DT bindings) before the patch using that compatible.
See also: https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Best regards,
Krzysztof