Re: [PATCH 3/3] arm64: dts: rockchip: drop max-link-speed = <2> in helios64 PCIe

[Dragan Simic]

Hello Geraldo,

On Saturday, November 15, 2025 10:10 CET, Geraldo Nascimento <geraldogabriel@xxxxxxxxx> wrote:
> Shawn Lin from Rockchip strongly discourages attempts to use their
> RK3399 PCIe core at 5.0 GT/s speed, citing concerns about catastrophic
> failures that may happen. Even if the odds are low, drop from last user
> of this property for the RK3399 platform, helios64.
> 
> Fixes: 755fff528b1b ("arm64: dts: rockchip: add variables for pcie completion to helios64")
> Link: https://lore.kernel.org/all/ffd05070-9879-4468-94e3-b88968b4c21b@xxxxxxxxxxxxxx/
> Reported-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
> Signed-off-by: Geraldo Nascimento <geraldogabriel@xxxxxxxxx>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> index e7d4a2f9a95e..78a7775c3b22 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> @@ -424,7 +424,6 @@ &pcie_phy {
>  
>  &pcie0 {
>  	ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
> -	max-link-speed = <2>;
>  	num-lanes = <2>;
>  	pinctrl-names = "default";
>  	status = "okay";

Looking good to me, this rounds up the prevention of issues
coming from buggy PCIe Gen2 on RK3399.

Please feel free to include

Reviewed-by: Dragan Simic <dsimic@xxxxxxxxxxx>

Though, could you, please, add patch 4/3 to this series, which
would remove the redundant parameter "max-link-speed = <1>" from
rk3399-nanopi-r4s.dtsi?