Re: [PATCH v8 5/6] gpu: nova-core: add boot42 support for next-gen GPUs

[John Hubbard]

On 11/14/25 6:01 AM, Alexandre Courbot wrote:
> On Fri Nov 14, 2025 at 11:41 AM JST, John Hubbard wrote:
> <snip>
>> +register!(NV_PMC_BOOT_42 @ 0x00000a00, "Extended architecture information" {
>> +    15:12   minor_revision as u8, "Minor revision of the chip";
>> +    19:16   major_revision as u8, "Major revision of the chip";
>> +    23:20   implementation as u8, "Implementation version of the architecture";
>> +    29:24   architecture as u8 ?=> Architecture, "Architecture value";
>> +});
>>  
>> -    /// Combines `architecture` and `implementation` to obtain a code unique to the chipset.
> 
> This comment for the `chipset` method got deleted. Is there a reason? If not I'll restore it when applying.

Ah yes. It got deleted because NV_PMC_BOOT_0::chipset() also got deleted.
And then, I didn't add a corresponding comment for NV_PMC_BOOT_42::chipset().

I'll add it. I have to respin anyway. Thanks for catching it!


thanks,
-- 
John Hubbard