Re: [PATCH 1/2] block/blk-throttle: Fix throttle slice time for SSDs

From: Jens Axboe

Date: Fri Nov 14 2025 - 15:51:49 EST


On 11/14/25 1:26 PM, Khazhy Kumykov wrote:
> On Wed, Jul 30, 2025 at 4:19 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>>
>> On 7/30/25 11:30, Yu Kuai wrote:
>> I had combined it because it is another left-over from bf20ab538c81 and
>> I don't know if enabling statistics has other side effects. But, sure,
>> I can split it out if that is preferred. Let's wait for feedback from
>> Jens and/or Tejun; I'll follow their guidance.
>>
>> Thanks,
>> Guenter
>>
> noticed this one in our carry queue... any further guidance here? If
> my opinion counts, since this is a fixup for a "remove feature X"
> commit... I would have done it in one commit as well :)

I agree with Yu that a split of patch 1 would be appropriate.

--
Jens Axboe