Re: [PATCH v3 09/20] mfd: sec: Add support for S2MPG11 PMIC via ACPM

[Mark Brown]

On Thu, Nov 13, 2025 at 09:43:29PM +0000, André Draszik wrote:
> On Thu, 2025-11-13 at 16:25 +0000, Lee Jones wrote:

> > > +static const struct mfd_cell s2mpg11_devs[] = {
> > > +	MFD_CELL_NAME("s2mpg11-meter"),
> > > +	MFD_CELL_BASIC("s2mpg11-regulator", NULL, NULL, 0, S2MPG11_BUCKBOOST),

> > This is highly irregular - in that, we've never done this before.

> > We're going to need to have Mark look at this.

> I did see this in at least one other driver, ah yes at least
> drivers/mfd/88pm860x-core.c is doing something similar, maybe others, too
> (I stopped there).

Other drivers doing something doesn't mean that they're following good
practice.  We do also have drivers which have multiple identical IP
blocks and are passing in resources with base address, interrupt and
whatever for the IP blocks which is different to just passing a Linux
internal ID number through.

Attachment: signature.asc
Description: PGP signature