Re: [PATCH v2 3/3] PCI/sysfs: Use PM_RUNTIME_ACQUIRE()/PM_RUNTIME_ACQUIRE_ERR()
From: Rafael J. Wysocki
Date: Fri Nov 14 2025 - 10:47:59 EST
On Fri, Nov 14, 2025 at 10:03 AM Dhruva Gole <d-gole@xxxxxx> wrote:
>
> On Nov 13, 2025 at 20:35:27 +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> >
> > Use new PM_RUNTIME_ACQUIRE() and PM_RUNTIME_ACQUIRE_ERR() wrapper macros
> > to make the code look more straightforward.
> >
> > No intentional funtional impact.
>
> Same here ...
Yup, will fix.
> Reviewed-by: Dhruva Gole <d-gole@xxxxxx>
Thanks!
Bjorn & PCI people, if there are any concerns regarding the change
below, please let me know.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > ---
> >
> > v1 -> v2: Adjust to the changes in patch [1/3].
> >
> > ---
> > drivers/pci/pci-sysfs.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > --- a/drivers/pci/pci-sysfs.c
> > +++ b/drivers/pci/pci-sysfs.c
> > @@ -1517,8 +1517,8 @@ static ssize_t reset_method_store(struct
> > return count;
> > }
> >
> > - ACQUIRE(pm_runtime_active_try, pm)(dev);
> > - if (ACQUIRE_ERR(pm_runtime_active_try, &pm))
> > + PM_RUNTIME_ACQUIRE(dev, pm);
> > + if (PM_RUNTIME_ACQUIRE_ERR(&pm))
> > return -ENXIO;
> >
> > if (sysfs_streq(buf, "default")) {
> >
> >
> >
>
> --