Re: [PATCH v2] ksmbd: server: avoid busy polling in accept loop

From: Simon Horman

Date: Fri Nov 14 2025 - 07:02:06 EST


On Tue, Nov 11, 2025 at 06:47:49PM +0800, Qingfang Deng wrote:

...

> @@ -458,10 +451,6 @@ static void tcp_destroy_socket(struct socket *ksmbd_socket)
> if (!ksmbd_socket)
> return;
>
> - /* set zero to timeout */
> - ksmbd_tcp_rcv_timeout(ksmbd_socket, 0);
> - ksmbd_tcp_snd_timeout(ksmbd_socket, 0);
> -

Hi Qingfang Deng,

W=1 builds tell me that ksmbd_tcp_rcv_timeout() is now unused:
I expect it can be removed.

> ret = kernel_sock_shutdown(ksmbd_socket, SHUT_RDWR);
> if (ret)
> pr_err("Failed to shutdown socket: %d\n", ret);

...