Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes
From: Xu Yilun
Date: Fri Nov 14 2025 - 04:51:56 EST
On Thu, Nov 13, 2025 at 08:12:24AM +0100, Krzysztof Kozlowski wrote:
> On 13/11/2025 06:55, Xu Yilun wrote:
> > On Thu, Nov 13, 2025 at 12:43:56PM +0800, Khairul Anuar Romli wrote:
> >> The Intel Agilex 5 SoC contains a programmable FPGA region that requires
> >> proper device tree description to enable FPGA manager support in the Linux
> >> kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot
> >> detect or manage the FPGA hardware correctly.
> >>
> >> This patch adds a 'fpga-region' node with compatible = "fpga-region", along
> >> with appropriate #address-cells and #size-cells properties, to describe the
> >> FPGA region layout.
> >>
> >> Also defines specific compatible string for Agilex5 and add Agilex string
> >> as fallback for stratix10-soc driver initialization.
> >>
> >> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@xxxxxxxxxx>
> >
> > Reviewed-by: Xu Yilun <yilun.xu@xxxxxxxxx>
>
> How this can be reviewed if it is completely wrong and obviously not
> matching the bindings from this patchset?
I apologize. Obviously I didn't pay enough effort on DT. Thanks for
pointing out and providing the Doc.
>
> Best regards,
> Krzysztof