Re: [PATCH 1/3] drm: zynqmp: Check property creation status

[Thomas Zimmermann]

Am 13.11.25 um 21:37 schrieb Sean Anderson:
> Make sure to return an error in the event that we can't create our
> properties.
>
> Fixes: 650f12042b85 ("drm: xlnx: zynqmp_dpsub: Add global alpha support")
> Fixes: 8c772f0b2b8e ("drm: xlnx: zynqmp_dpsub: Expose plane ordering to userspace")
>
> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxxx>

Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

> ---
>
>   drivers/gpu/drm/xlnx/zynqmp_kms.c | 12 +++++++++---
>   1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> index 2bee0a2275ed..c80a2d4034f3 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> @@ -174,9 +174,15 @@ static int zynqmp_dpsub_create_planes(struct zynqmp_dpsub *dpsub)
>   
>   		drm_plane_helper_add(plane, &zynqmp_dpsub_plane_helper_funcs);
>   
> -		drm_plane_create_zpos_immutable_property(plane, i);
> -		if (i == ZYNQMP_DPSUB_LAYER_GFX)
> -			drm_plane_create_alpha_property(plane);
> +		ret = drm_plane_create_zpos_immutable_property(plane, i);
> +		if (ret)
> +			return ret;
> +
> +		if (i == ZYNQMP_DPSUB_LAYER_GFX) {
> +			ret = drm_plane_create_alpha_property(plane);
> +			if (ret)
> +				return ret;
> +		}
>   	}
>   
>   	return 0;

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)