Re: linux-next: Fixes tag needs some work in the block tree

[Damien Le Moal]

On 11/14/25 8:45 AM, Jens Axboe wrote:
> On 11/13/25 4:38 PM, Damien Le Moal wrote:
>> On 11/14/25 8:07 AM, Jens Axboe wrote:
>>> On 11/13/25 3:04 PM, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>>   7b2038b1b1d4 ("dm: fix zone reset all operation processing")
>>>>
>>>> Fixes tag
>>>>
>>>>   Fixes: db9aed869f34 ("block: introduce disk_report_zone()").
>>>>
>>>> has these problem(s):
>>>>
>>>>   - Target SHA1 does not exist
>>>>
>>>> Maybe you meant
>>>>
>>>> Fixes: fdb9aed869f3 ("block: introduce disk_report_zone()")
>>>
>>> Guys, that's now three funky shas that have never existed in my tree.
>>> Can we please exercise a bit more diligence in actually tagging patches
>>> correctly?
>>
>> My apologies about this. I was careful to take these from a fresh pull of
>> block/for-next but I obviously screwed-up the copy paste, missing the first
>> character.
> 
> Just add something like this to your git config:
> 
> [core]
> 	abbrev = 12
> [pretty] 
> 	fixes = Fixes: %h (\"%s\")
> [alias]
> 	fixes = log -1 --format=fixes
> 
> and then you just do:
> 
> axboe@m2max ~/gi/linux (for-next)> git fixes fdb9aed869f34d776298b3a8197909eb820e4d0d
> Fixes: fdb9aed869f3 ("block: introduce disk_report_zone()")
> 
> and then you're just copying that entire line, making an error much less
> likely. Still won't catch someone using the wrong SHA, but it would've
> prevented your issue at least.

Will do. Thanks.


-- 
Damien Le Moal
Western Digital Research