Re: [PATCH v2 1/3] dt-bindings: arm: realtek: Add Kent Soc family compatibles

[Conor Dooley]

On Thu, Nov 13, 2025 at 08:30:07PM +0800, Yu-Chun Lin wrote:
> Define compatible strings for Realtek RTD1501s, RTD1861b and RTD1920s.
> 

> Additionally, convert legacy DTS-style comments to YAML description
> properties, following the pattern from the ARM bindings conversion series
> [1].

"Additionally" is often a sign that it should be in a different patch.
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
pw-bot: not-applicable

> 
> [1] https://lore.kernel.org/lkml/20200622125527.24207-2-afaerber@xxxxxxx/
> 
> Signed-off-by: Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>
> ---
>  .../devicetree/bindings/arm/realtek.yaml      | 42 +++++++++++++------
>  1 file changed, 30 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml
> index ddd9a85099e9..be529490640c 100644
> --- a/Documentation/devicetree/bindings/arm/realtek.yaml
> +++ b/Documentation/devicetree/bindings/arm/realtek.yaml
> @@ -14,21 +14,21 @@ properties:
>      const: '/'
>    compatible:
>      oneOf:
> -      # RTD1195 SoC based boards
> -      - items:
> +      - description: RTD1195 SoC based boards
> +        items:
>            - enum:
>                - mele,x1000 # MeLE X1000
>                - realtek,horseradish # Realtek Horseradish EVB
>            - const: realtek,rtd1195
>  
> -      # RTD1293 SoC based boards
> -      - items:
> +      - description: RTD1293 SoC based boards
> +        items:
>            - enum:
>                - synology,ds418j # Synology DiskStation DS418j
>            - const: realtek,rtd1293
>  
> -      # RTD1295 SoC based boards
> -      - items:
> +      - description: RTD1295 SoC based boards
> +        items:
>            - enum:
>                - mele,v9 # MeLE V9
>                - probox2,ava # ProBox2 AVA
> @@ -36,25 +36,43 @@ properties:
>                - zidoo,x9s # Zidoo X9S
>            - const: realtek,rtd1295
>  
> -      # RTD1296 SoC based boards
> -      - items:
> +      - description: RTD1296 SoC based boards
> +        items:
>            - enum:
>                - synology,ds418 # Synology DiskStation DS418
>            - const: realtek,rtd1296
>  
> -      # RTD1395 SoC based boards
> -      - items:
> +      - description: RTD1395 SoC based boards
> +        items:
>            - enum:
>                - bananapi,bpi-m4 # Banana Pi BPI-M4
>                - realtek,lion-skin # Realtek Lion Skin EVB
>            - const: realtek,rtd1395
>  
> -      # RTD1619 SoC based boards
> -      - items:
> +      - description: RTD1501s SoC based boards
> +        items:
> +          - enum:
> +              - realtek,phantom # Realtek Phantom EVB (8GB)
> +          - const: realtek,rtd1501s
> +
> +      - description: RTD1619 SoC based boards
> +        items:
>            - enum:
>                - realtek,mjolnir # Realtek Mjolnir EVB
>            - const: realtek,rtd1619
>  
> +      - description: RTD1861b SoC based boards
> +        items:
> +          - enum:
> +              - realtek,krypton # Realtek Krypton EVB (8GB)
> +          - const: realtek,rtd1861b
> +
> +      - description: RTD1920s SoC based boards
> +        items:
> +          - enum:
> +              - realtek,smallville # Realtek Smallville EVB (4GB)
> +          - const: realtek,rtd1920s
> +
>  additionalProperties: true
>  
>  ...
> -- 
> 2.34.1
>

Attachment: signature.asc
Description: PGP signature