Re: [PATCH] net: ethernet: broadcom: replace strcpy with strscpy

[David Laight]

On Thu, 13 Nov 2025 13:55:17 +0530
Shi Hao <i.shihao.999@xxxxxxxxx> wrote:

> Replace strcpy function calls with strscpy to ensure bounds checking
> in the destination buffer, preventing buffer overflows and improving
> security. This change aligns with current kernel coding guidelines
> and best practices.
> 
...
> -			strcpy(tp->board_part_number, "BCM5717");
> +			strscpy(tp->board_part_number, "BCM5717", TG3_BPN_SIZE);

No one really knows that TG3_BPN_SIZE is in any way related to the destination.
So this doesn't actually make the code that much better at all.

Since tp->board_part_number is an array and "BCM5717" a constant I suspect
there is already a compile-time check that the string fits.
The strcpy() will also be converted to a memcpy().

So all, in all, this makes the code worse on several fronts.

	David