Re: [PATCH 7/8] hwmon:(ina3221)Support read/write functions for 'power' attribute

From: Guenter Roeck

Date: Thu Nov 13 2025 - 12:18:32 EST


On Tue, Nov 11, 2025 at 03:05:45AM -0500, Wenliang Yan wrote:
> SQ52210 adds power attribute to report power data, and implements
> read/write functions for this purpose.
>
> Signed-off-by: Wenliang Yan <wenliang202407@xxxxxxx>
> ---
> drivers/hwmon/ina3221.c | 79 ++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 75 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
> index abb6049c8eab..ea01687ad1fa 100644
> --- a/drivers/hwmon/ina3221.c
> +++ b/drivers/hwmon/ina3221.c
> @@ -348,19 +348,16 @@ static const u8 ina3221_in_reg[] = {
> INA3221_SHUNT3,
> INA3221_SHUNT_SUM,
> };
> -
> static const u8 alert_limit_reg[] = {
> SQ52210_ALERT_LIMIT1,
> SQ52210_ALERT_LIMIT2,
> SQ52210_ALERT_LIMIT3,
> };
> -
> static const u8 alert_flag[] = {
> F_AFF1,
> F_AFF2,
> F_AFF3,
> };
> -

Please refrain from making such cosmetic changes.

Guenter